Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0] [MIG] connector_magento #274

Open
wants to merge 10 commits into
base: 11.0
Choose a base branch
from

Conversation

hugosantosred
Copy link
Member

@hugosantosred hugosantosred commented Mar 6, 2018

Migrated connector_magento to V11

Depends on:

guewen and others added 6 commits March 6, 2018 18:01
Restructure files, split large python files

Fix views

* Add binding on sales orders
* Ensure that we always have the Connector Manager group on the
  Connector tabs (most are done in the parent views of
  connector_ecommerce)
* Fixed inheritance of the delivery.carrier view

Collection.work_on is now a context manager

Add a base listener and use it in partner export

Rewrite tests using new API and vcr.py

* Use vcr.py to record the exchanges instead of a self-made recorder
* Use new base Components test case classes
* Separate export tests in 2 phases: trigger of the export which check
  that the jobs are delayed, and test the job itself in a second test

Update documentation

Various fixes

Add dependency on product_multi_category

I removed it earlier, but it is required when we import products
Fix Pylint warnings

Remove deprecated select for index creation

[FIX] pass http credentials to backedn component if required

[FIX] change user on backend otherwise import sale order will be done on the wrong one

[CHG]review product aggregation by backend to improve performance
Remove related_action from import_batch
Add Magento Enterprise Gift Cards payment line.

Unpacks the giftcard code from the PHP serialized information about the giftcards using regex.

Don't add a 0 amount Giftcard line.

Since the value will be a string like '0.0000', the prior tests were insufficient to prevent always adding a line.
Fix failing test

* Rename it because it was shadowing another test
* Compute in the location's context
Add Rewards and StoreCredit payment methods.

(Travis Bump)
@hugosantosred hugosantosred mentioned this pull request Mar 6, 2018
1 task
@hugosantosred hugosantosred force-pushed the 11.0-mig-connector_magento branch 2 times, most recently from a059f22 to 5ff679d Compare March 6, 2018 17:53
@pedrobaeza pedrobaeza added this to the 11.0 milestone Mar 6, 2018

This is the new release of the Open-Source connector linking Odoo and
Magento also known under the name of **Magentoerpconnect**. It is
build on top of the `connector`_ framework. It is is structured so that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is structured

@mlaitinen
Copy link

base_technical_user has been merged

self.env[model_name].import_batch(backend)
return True
except Exception as e:
_logger.error(e.message, exc_info=True)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This call will fail because the Exception e doesn't have an attribute called message

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Done. Now Uses the ustr method from Odoo base to print the exception as text.

@hugosantosred hugosantosred force-pushed the 11.0-mig-connector_magento branch 5 times, most recently from 995ed4d to 8cce753 Compare July 12, 2018 11:25
<field eval="False" name="doall"/>
<field ref="connector_magento.model_magento_backend" name="model_id"/>
<field eval="'_scheduler_import_sale_orders'" name="function"/>
<field eval="'()'" name="args"/>
Copy link
Member

@jesusVMayor jesusVMayor Jul 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to
<field name="state">code</field>
<field name="code">model._scheduler_import_sale_orders()</field>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Done, sorry for the delay!

@janarthanandev
Copy link

Does this connector works for Magento 2

@jesusVMayor
Copy link
Member

@janarthanandev
#211
https://github.com/Comunitea/connector-magento/commits/11.0_magento2

@infoitservit
Copy link

Hi...there is some news? Could i test it on my odoo v11?

@pedrobaeza
Copy link
Member

This one misses some commit history from 10.0 (maybe added afterwards) and Travis is red.

@jaredkipe
Copy link

@jesusVMayor I cannot seem to make a pull request from my version of this, but on ~line 39 of "connector_magento/models/stock_picking/exporter.py"
-- sale_line = line.procurement_id.sale_line_id
++ sale_line = line.sale_line_id

@seyuf
Copy link

seyuf commented Aug 25, 2020

@jaredkipe have you tested @jesusVMayor 's module for magento2? Is it working? If so could you provide the m2 version with whom it worked? Thanks for any feedback.

@atchuthan
Copy link
Member

May I know the status of this PR?
Does the code support magento2?

@StefanRijnhart
Also, is there any plan to downgrade the v12 branch(from PR: #304) as v12 supports magento2 too?

@StefanRijnhart
Copy link
Member

No plan, but it should not be too hard I think.

@jaredkipe
Copy link

@seyuf We have had M1 on 11 for a long time stable in production. We are currently in a AB testing situation with M1 and M2 (2.3) at the same time, there are some issues here and there that I've been fixing as we go.

@seyuf
Copy link

seyuf commented Oct 8, 2020

Hi @jaredkipe ,
Thanks for the feedback. It would be nice if you could submit a link to a repo/fork with your fixes and/or a PR.
Also, if i understood correctly, you're so far, just dealing with minor issues? Nothing critical?
And concerning your M 2.3 is MSI enabled?

@jaredkipe
Copy link

@seyuf
https://github.com/hibou-io/oca-connector-magento
Feel free to pull/merge.

I wouldn't say they're all minor (but maybe you do consider it minor), like this pricing fix. hibou-io@4a08c45

We do not use MSI because we already have customizations related to combining inventory from more than one stock location as the stock qty, and advanced order planning to direct orders to closest warehouse or splitting if there are stock issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.